-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove config flag as a global Flag + setting config default location to /etc/k0s/k0s.yaml #1389
Conversation
3566049
to
b50bf8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This includes all the kubectl docs in the cli/docs
With #1376 all the docs/cli stuff could be dropped.
0cd3419
to
6ad3d88
Compare
I listed the wrong issue. description fixed. |
6a180c2
to
269ab5f
Compare
0c3da92
to
5d5e0ae
Compare
53817bc
to
0b4b16a
Compare
Would love to have a comment in the commit message explaining why we remove --config as global flag and why we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure the config file is closed after it is read (unless we read from stdin)
0b4b16a
to
2772bc0
Compare
this commit removes config as a global flag so that it will not show up in commands that don't use it (for example, worker). it also sets the default config path to /etc/k0s/k0s.yaml since it is already the de-facto location for k0sctl and also appears in our documenttation. Signed-off-by: Karen Almog <[email protected]>
Signed-off-by: Karen Almog <[email protected]>
Signed-off-by: Karen Almog <[email protected]>
2772bc0
to
5e2aa11
Compare
Fixes #1369 #1222
This PR is a sub-section of the work entailed in the original config-refactoring PR (#1247), since a rebase was too complex.
It includes: